adoroszlai commented on code in PR #4582:
URL: https://github.com/apache/ozone/pull/4582#discussion_r1169809485


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java:
##########
@@ -978,20 +977,22 @@ public boolean isBucketEmpty(String volume, String bucket)
    */
   private boolean isKeyPresentInTableCache(String keyPrefix,
                                            Table table) {

Review Comment:
   ```suggestion
                                              Table<String, ?> table) {
   ```
   
   Note: caller should also be changed to pass `getDirectoryTable()` instead of 
`dirTable`.



##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java:
##########
@@ -1001,18 +1002,18 @@ private boolean isKeyPresentInTableCache(String 
keyPrefix,
    * @throws IOException
    */
   private boolean isKeyPresentInTable(String keyPrefix,
-                                      Table<String, OmKeyInfo> table)
+                                      Table table)

Review Comment:
   Same here.
   
   ```suggestion
                                         Table<String, ?> table)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to