smengcl commented on code in PR #4651:
URL: https://github.com/apache/ozone/pull/4651#discussion_r1186532937
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java:
##########
@@ -367,9 +368,11 @@ public static DBCheckpoint createOmSnapshotCheckpoint(
dbCheckpoint = store.getSnapshot(snapshotInfo.getCheckpointDirName());
// Clean up active DB's deletedTable right after checkpoint is taken,
// with table write lock held
- deleteKeysInSnapshotScopeFromDTableInternal(omMetadataManager,
+ deleteKeysFromDelKeyTableInSnapshotScope(omMetadataManager,
+ snapshotInfo.getVolumeName(), snapshotInfo.getBucketName());
+ // Clean up deletedDirectoryTable as well
+ deleteKeysFromDelDirTableInSnapshotScope(omMetadataManager,
Review Comment:
I intended to share the `DELETED_TABLE` lock. Now that you bring this up we
might need to add a new lock because of `DirectoryDeletingService`. Will take a
look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
