[
https://issues.apache.org/jira/browse/HDDS-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728132#comment-17728132
]
Siyao Meng edited comment on HDDS-8732 at 5/31/23 8:58 PM:
-----------------------------------------------------------
This looks to be a bug in "snapshot list" command.
When snapshot listing is iterating over the DB it doesn't check whether the
entry is already populated from the cache and is incorrectly overwriting it in
{{appendSnapshotFromDBToMap}}.
The solution would be to *either*:
1. in {{appendSnapshotFromDBToMap}}, skip the result entry population if the
entry already exists because it is already populated from the cache (which is
the source of truth)
2. or swap the order of calls to {{appendSnapshotFromDBToMap}} and
{{appendSnapshotFromCacheToMap}}.
Thanks [~aswinshakil] for pointing this out.
cc [~wfps1210] [~ppogde]
was (Author: smeng):
This looks to be a bug in "snapshot list" command.
When snapshot listing is iterating over the DB it doesn't check whether the
entry is already populated from the cache and is overwriting it in
{{appendSnapshotFromDBToMap}}.
The solution would be to *either*:
1. in {{appendSnapshotFromDBToMap}}, skip the result entry population if the
entry already exists because it is already populated from the cache (which is
the source of truth)
2. or swap the order of calls to {{appendSnapshotFromDBToMap}} and
{{appendSnapshotFromCacheToMap}}.
Thanks [~aswinshakil] for pointing this out.
cc [~wfps1210] [~ppogde]
> Intermittent failure at Delete snapshot in upgrade test
> -------------------------------------------------------
>
> Key: HDDS-8732
> URL: https://issues.apache.org/jira/browse/HDDS-8732
> Project: Apache Ozone
> Issue Type: Sub-task
> Components: Snapshot
> Affects Versions: 1.4.0
> Reporter: Attila Doroszlai
> Assignee: Dave Teng
> Priority: Critical
>
> {code:title=https://github.com/apache/ozone/actions/runs/5127514810/jobs/9223531259#step:5:899}
> Delete snapshot | FAIL |
> '[ {
> "volumeName" : "snapvolume-1",
> "bucketName" : "snapbucket-1",
> "name" : "snapshot2",
> "creationTime" : 1685495519725,
> "snapshotStatus" : "SNAPSHOT_ACTIVE",
> "snapshotID" : "206b010f-499e-4ce3-95c4-cc737d6f1003",
> "snapshotPath" : "snapvolume-1/snapbucket-1",
> "checkpointDir" : "-206b010f-499e-4ce3-95c4-cc737d6f1003"
> } ]' does not contain 'SNAPSHOT_DELETED'
> ------------------------------------------------------------------------------
> Upgrade-Snapshot-Check :: Smoketest ozone cluster snapshot feature | FAIL |
> {code}
> CC [~dteng], [~smeng]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
