devmadhuu commented on code in PR #4764:
URL: https://github.com/apache/ozone/pull/4764#discussion_r1224162568
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/OMDBInsightEndpoint.java:
##########
@@ -139,6 +161,9 @@ public Response getOpenKeyInfo(
KeyInsightInfoResponse openKeyInsightInfo = new KeyInsightInfoResponse();
List<KeyEntityInfo> nonFSOKeyInfoList =
openKeyInsightInfo.getNonFSOKeyInfoList();
+
+ // Create a HashMap for the clusterSummary
+ Map<String, Object> clusterSummary = new HashMap<>();
Review Comment:
I think this should not be named as "clusterSummary", can we rename as
"keysSummary"
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/KeyInsightInfoResponse.java:
##########
@@ -23,25 +23,31 @@
import org.apache.hadoop.ozone.om.helpers.RepeatedOmKeyInfo;
import java.util.ArrayList;
+import java.util.HashMap;
import java.util.List;
+import java.util.Map;
/**
* HTTP Response wrapped for keys insights.
*/
public class KeyInsightInfoResponse {
+ /** Cluster summary. Includes aggregated information about the cluster. */
+ @JsonProperty("clusterSummary")
Review Comment:
Pls change it to "keysSummary"
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/OMDBInsightEndpoint.java:
##########
@@ -69,66 +79,78 @@ public class OMDBInsightEndpoint {
private ReconContainerMetadataManager reconContainerMetadataManager;
private final ReconOMMetadataManager omMetadataManager;
private final ReconContainerManager containerManager;
+ private static final Logger LOG =
+ LoggerFactory.getLogger(OMDBInsightEndpoint.class);
+ private GlobalStatsDao globalStatsDao;
Review Comment:
pls make it final
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
