swamirishi commented on code in PR #4811:
URL: https://github.com/apache/ozone/pull/4811#discussion_r1227361334
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/SnapshotDeletingService.java:
##########
@@ -610,6 +615,37 @@ public void submitRequest(OMRequest omRequest) {
}
}
+ public static boolean isBlockLocationInfoSame(OmKeyInfo prevKeyInfo,
+ OmKeyInfo deletedKeyInfo) {
+ OmKeyLocationInfoGroup deletedOmKeyLocation =
+ deletedKeyInfo.getLatestVersionLocations();
Review Comment:
I guess this is the blockLocationList correct me if I wrong, I wanted to
just put another check on the number of versions are also same. Just to be on
the safe side so that we don't end up deleting some random data because of some
bug in the version maintenance. Say if they start supporting bucket versioning
deletion of particular version. Out here we are just checking it for the
latestVersion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
