GeorgeJahad commented on code in PR #4567:
URL: https://github.com/apache/ozone/pull/4567#discussion_r1232879072
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java:
##########
@@ -246,15 +246,8 @@ public OmSnapshotManager(OzoneManager ozoneManager) {
}
};
- // init LRU cache
- this.snapshotCache = CacheBuilder.newBuilder()
- // Indicating OmSnapshot instances are softly referenced from the
cache.
- // If no thread is holding a strong reference to an OmSnapshot instance
- // (e.g. SnapDiff), the instance could be garbage collected by JVM at
- // its discretion.
- .softValues()
Review Comment:
> Would you like to file a new jira for this?
Nope, just wanted to clarify. (I didn't remember us saying we would replace
the other approach.)
But now I'm confused about why we are using
com.google.common.cache.CacheLoader and
com.google.common.cache.RemovalListener. Do we still need those?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
