GeorgeJahad commented on code in PR #4567:
URL: https://github.com/apache/ozone/pull/4567#discussion_r1240021963
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java:
##########
@@ -246,15 +246,8 @@ public OmSnapshotManager(OzoneManager ozoneManager) {
}
};
- // init LRU cache
- this.snapshotCache = CacheBuilder.newBuilder()
- // Indicating OmSnapshot instances are softly referenced from the
cache.
- // If no thread is holding a strong reference to an OmSnapshot instance
- // (e.g. SnapDiff), the instance could be garbage collected by JVM at
- // its discretion.
- .softValues()
Review Comment:
Sorry if I'm being dense, but I'm still not following. What is the actual
data structure currently storing the cache? Is it a
com.google.common.cache.CacheLoader? What kind of cache is that? Does it have
an eviction policy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
