[ 
https://issues.apache.org/jira/browse/HDDS-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742144#comment-17742144
 ] 

Attila Doroszlai commented on HDDS-2985:
----------------------------------------

Based on the date this bug was reported, {{HddsDispatcher}} probably looked 
like this:

{code:title=https://github.com/apache/ozone/blob/650678928c0f8032a3935757884e20710eebc775/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java#L223-L228}
 223   │       Preconditions.checkNotNull(container2BCSIDMap);
 224   │       if (container2BCSIDMap.get(containerID) == null) {
 225   │         container2BCSIDMap
 226   │             .put(containerID, container.getBlockCommitSequenceId());
 227   │         containerSet.getMissingContainerSet().remove(containerID);
 228   │       }
{code}

Only {{container}} could have been null, and null check for that was added in 
HDDS-3115.

> When changing ratis code with not wait for WSMD future got NPE with no clear 
> exception
> --------------------------------------------------------------------------------------
>
>                 Key: HDDS-2985
>                 URL: https://issues.apache.org/jira/browse/HDDS-2985
>             Project: Apache Ozone
>          Issue Type: Bug
>            Reporter: Bharat Viswanadham
>            Assignee: George Jahad
>            Priority: Major
>              Labels: teragentest
>
>  
> {code:java}
>    2020-02-05 14:18:45,975 ERROR 
> org.apache.hadoop.ozone.container.common.transport.server.ratis.ContainerStateMachine:
>  gid group-4736BBD10AF6 : ApplyTransaction failed. cmd WriteChunk logIndex 15 
> exception {} java.lang.NullPointerException at 
> org.apache.hadoop.ozone.container.common.impl.HddsDispatcher.dispatchRequest(HddsDispatcher.java:226)
>  at 
> org.apache.hadoop.ozone.container.common.impl.HddsDispatcher.dispatch(HddsDispatcher.java:162)
>  at 
> org.apache.hadoop.ozone.container.common.transport.server.ratis.ContainerStateMachine.dispatchCommand(ContainerStateMachine.java:396)
>  at 
> org.apache.hadoop.ozone.container.common.transport.server.ratis.ContainerStateMachine.runCommand(ContainerStateMachine.java:406)
>  at 
> org.apache.hadoop.ozone.container.common.transport.server.ratis.ContainerStateMachine.lambda$applyTransaction$6(ContainerStateMachine.java:745)
>  at 
> java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1604)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  at java.lang.Thread.run(Thread.java:748) 2020-02-05 14:18:45,975 ERROR 
> org.apache.hadoop.ozone.container.common.transport.server.ratis.ContainerStateMachine:
>  gid group-4736BBD10AF6 : ApplyTransaction failed. cmd WriteChunk logIndex 17 
> exception {} java.lang.NullPointerException at 
> org.apache.hadoop.ozone.container.common.impl.HddsDispatcher.dispatchRequest(HddsDispatcher.java:226)
>  at 
> org.apache.hadoop.ozone.container.common.impl.HddsDispatcher.dispatch(HddsDispatcher.java:162)
>  at 
> org.apache.hadoop.ozone.container.common.transport.server.ratis.ContainerStateMachine.dispatchCommand(ContainerStateMachine.java:396)
>  at 
> org.apache.hadoop.ozone.container.common.transport.server.ratis.ContainerStateMachine.runCommand(ContainerStateMachine.java:406)
>  at 
> org.apache.hadoop.ozone.container.common.transport.server.ratis.ContainerStateMachine.lambda$applyTransaction$6(ContainerStateMachine.java:745)
>  at 
> java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1604)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  at java.lang.Thread.run(Thread.java:748)     {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to