duongkame commented on code in PR #5131:
URL: https://github.com/apache/ozone/pull/5131#discussion_r1289039754


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataReader.java:
##########
@@ -323,8 +323,11 @@ public List<OmKeyInfo> listKeys(String volumeName, String 
bucketName,
             bucket.realVolume(), bucket.realBucket(), keyPrefix);
       }
       metrics.incNumKeyLists();
-      return keyManager.listKeys(bucket.realVolume(), bucket.realBucket(),
-          startKey, keyPrefix, maxKeys);
+      List<OmKeyInfo> omKeyInfoList =

Review Comment:
   Should this metric be captured outside to take every cost, including bucket 
resolving and ACL check into account? Seems like we need a simple breakdown of 
the metric.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to