swamirishi commented on PR #5190: URL: https://github.com/apache/ozone/pull/5190#issuecomment-1679743639
> Change looks good to me. > > The only question I've is how current tests are working without it. Do we or not have test when `NATIVE_LIB_TMP_DIR` is not set? If not, we should have that. Yeah NATIVE_LIB_TMP_DIR is set for CI runs. https://github.com/apache/ozone/blob/a1a9471f17ca56d0bc12912f25cf922da93f26c3/hadoop-ozone/dev-support/checks/junit.sh#L32 > > If tests are covered in #5165, that's also fine for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
