smengcl commented on PR #5175: URL: https://github.com/apache/ozone/pull/5175#issuecomment-1683116257
> Thanks @smengcl for the patch. nit: An assert statement should also be created in TestOMSnapshotCreateRequest#testValidateAndUpdateCache & TestOmSnapshotCreateResponse#testAddToDBBatch. Otherwise the patch looks good to me Added in `TestOMSnapshotCreateRequest`. It is not making much sense to add the check in `TestOmSnapshotCreateResponse` since it does not concern the `Request` change in this PR. `testAddToDBBatch` is crafting its own `OMSnapshotCreateResponse` object just to test `addToDBBatch` and does not go through `validateAndUpdateCache` at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
