devmadhuu commented on code in PR #5154:
URL: https://github.com/apache/ozone/pull/5154#discussion_r1297952071
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/insights.tsx:
##########
@@ -262,6 +267,10 @@ export class Insights extends
React.Component<Record<string, object>, IInsightsS
});
}
+ componentWillUnmount(): void {
+ cancelInsightSignal && cancelInsightSignal.abort();
Review Comment:
Are we not adding any message here in abort function like we did in
heatmap.tsx ?
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/om/om.tsx:
##########
@@ -448,14 +454,34 @@ export class Om extends React.Component<Record<string,
object>, IOmdbInsightsSta
this.fetchMismatchContainers(this.state.DEFAULT_LIMIT,
this.state.prevKeyMismatch, this.state.mismatchMissingState);
};
+ componentWillUnmount(): void {
+ cancelMismatchedEndpointSignal && cancelMismatchedEndpointSignal.abort();
Review Comment:
Are we not adding any message here in all abort functions like we did in
heatmap.tsx ? Pls check all Unmount functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
