devabhishekpal commented on code in PR #5213:
URL: https://github.com/apache/ozone/pull/5213#discussion_r1303406766
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/utils/columnSearch.tsx:
##########
@@ -69,8 +69,15 @@ class ColumnSearch extends React.PureComponent {
filterIcon: (filtered: boolean) => (
<Icon type='search' style={{color: filtered ? '#1890ff' : undefined}}/>
),
- onFilter: (value: string, record: any) =>
- record[dataIndex].toString().toLowerCase().includes(value.toLowerCase()),
+ onFilter: (value: string, record: any) => {
+ if (record[dataIndex]) {
+ return typeof (record[dataIndex]) == 'object' ?
Object.values(...record[dataIndex]).toString().toLowerCase().includes(value.toLowerCase())
Review Comment:
Since object can have many different meanings, just to be on a safer side
can we do a stricter typecheck?
Something like:
`typeof(record[dataIndex]) === typeof({})`
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/utils/columnSearch.tsx:
##########
@@ -69,8 +69,15 @@ class ColumnSearch extends React.PureComponent {
filterIcon: (filtered: boolean) => (
<Icon type='search' style={{color: filtered ? '#1890ff' : undefined}}/>
),
- onFilter: (value: string, record: any) =>
- record[dataIndex].toString().toLowerCase().includes(value.toLowerCase()),
+ onFilter: (value: string, record: any) => {
+ if (record[dataIndex]) {
+ return typeof (record[dataIndex]) == 'object' ?
Object.values(...record[dataIndex]).toString().toLowerCase().includes(value.toLowerCase())
Review Comment:
Can we shorten the lines to keep at par with the code-style/readability?
```
return typeof (record[dataIndex] == 'object'
?
Object.values(...record[dataIndex]).toString().toLowerCase().includes(value.toLowerCase())
:
record[dataIndex].toString().toLowerCase().includes(value.toLowerCase())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
