szetszwo commented on code in PR #5251:
URL: https://github.com/apache/ozone/pull/5251#discussion_r1318730825
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockOutputStream.java:
##########
@@ -703,6 +705,19 @@ CompletableFuture<ContainerCommandResponseProto>
writeChunkToContainer(
LOG.debug("Writing chunk {} length {} at offset {}",
chunkInfo.getChunkName(), effectiveChunkSize, offset);
}
+
+ final ChunkInfo previous = previousChunkInfo.getAndSet(chunkInfo);
+ final long expectedOffset = previous == null ? 0
+ : chunkInfo.getChunkName().equals(previous.getChunkName()) ?
Review Comment:
Anyway, let's keep the current code since it is logically correct although
the chunk names seem to never be equal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
