szetszwo commented on PR #5377: URL: https://github.com/apache/ozone/pull/5377#issuecomment-1745266010
> What does this do for us eliminating the copy? Most requests will end up in the RocksDB or come out of the RocksDB I think, so does that mean most of the time we will need to make an extra copy of the buffer, or most of the time we will not with this change? When the backing buffer of the `ByteString` is direct, this change can eliminate the copying. In `TestStatefulServiceStateManagerImpl`, we did not use direct buffer. However, the `ByteString` received by gRPC could use direct buffer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
