guohao-rosicky commented on PR #5408: URL: https://github.com/apache/ozone/pull/5408#issuecomment-1792211718
> Currently, `OzoneLockStrategy` patterns are only being used for key create request. > > Is the motivation behind this change to reduce lock contention by changing behavior of the locking mechanism (when `ozone.om.key.path.lock.enabled` is set to `true`) at runtime? Actually this PR I just want to improve the speed of deletion of a bucket with a layout like object store. For other layout buckets I agree with what you said about ``` Can we parameterize the tests based on the configuration flags passed: ozone.om.key.path.lock.enabled and ozone.om.enable.filesystem.paths to either use OBSKeyPathLockStrategy (finer KEY_PREFIX_LOCK) or RegularBucketLockStrategy (BUCKET_LOCK) pattern implementations depending on this [logic](https://github.com/apache/ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/lock/OzoneLockProvider.java#L37-L52) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
