swamirishi opened a new pull request, #5619: URL: https://github.com/apache/ozone/pull/5619
## What changes were proposed in this pull request? Snapshot list might be missing entries in the return list. Currently the list happens in a paginated fashion getting few snapshots at a time. Thus every page updates the previous value as the last entry in the previous page, helping the api to seek to the next snapshot directly. The problem is we form the listing by getting the first few entries from the cache and then the remaining entries from the table and return the concatenated list. Consider the case: TableCache has snap100...snap125 RocksDB Table has snap0...snap99 Now we want to list all snapshots from snap50 with maxPageSize of 30: The expected list should be: snap50 to snap80 But the current output is snap50 to snap54 ... snap100 to snap125 which is wrong. The next page would start from snap125, thus missing the snapshot 55 to snap100 altogether. The ideal approach would be to merge these two streams and get the snapshots in a sorted order. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-9710 ## How was this patch tested? Existing UT. Will be adding a few more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
