adoroszlai commented on code in PR #3842:
URL: https://github.com/apache/ozone/pull/3842#discussion_r1403441962
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneBucket.java:
##########
@@ -650,11 +650,12 @@ public long getUsedNamespace() {
* keys if key prefix is null.
*
* @param keyPrefix Bucket prefix to match
+ * @param delimiter A delimiter to group matched keys
* @return {@code Iterator<OzoneKey>}
*/
- public Iterator<? extends OzoneKey> listKeys(String keyPrefix)
- throws IOException {
- return listKeys(keyPrefix, null);
+ public Iterator<? extends OzoneKey> listKeys(String keyPrefix,
+ String delimiter) throws IOException {
Review Comment:
I think we should keep the existing signature, too, and pass `null` for
`delimiter` to avoid unnecessarily breaking existing code using Ozone client
API.
This would also help reduce the change by not having to add `null` in all
known callers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
