sodonnel commented on code in PR #5632:
URL: https://github.com/apache/ozone/pull/5632#discussion_r1411887820
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/health/DeletingContainerHandler.java:
##########
@@ -70,6 +70,12 @@ public boolean handle(ContainerCheckRequest request) {
LOG.debug("Checking container {} in DeletingContainerHandler",
containerInfo);
Review Comment:
The lifecycle states are updated outside of the handlers and are nothing
more than the container state. I can update them on the report at the new entry
method for completeness.
```
for (ContainerInfo c : containers) {
if (!shouldRun()) {
break;
}
report.increment(c.getState());
if (rmConf.isLegacyEnabled() && !isEC(c.getReplicationConfig())) {
legacyReplicationManager.processContainer(c, report);
continue;
}
try {
processContainer(c, newRepQueue, report);
// TODO - send any commands contained in the health result
} catch (ContainerNotFoundException e) {
LOG.error("Container {} not found", c.getContainerID(), e);
}
}
```
This is where they are updated for the full runs - however the state can be
changed by the processing I think (unless its read only), so the setting maybe
should move after the chain is processed. I will check that and see if another
PR is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
