tanvipenumudy commented on code in PR #5391: URL: https://github.com/apache/ozone/pull/5391#discussion_r1483851945
########## hadoop-hdds/common/pom.xml: ########## @@ -206,6 +206,10 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";> <artifactId>junit-platform-launcher</artifactId> <scope>test</scope> </dependency> + <dependency> + <groupId>org.apache.ozone</groupId> + <artifactId>hdds-interface-server</artifactId> + </dependency> Review Comment: Instead of code refactoring, seeing if shifting the newly introduced proto message definitions to `ScmAdminProtocol.proto` (`StorageContainerLocationProtocolProtos`) would avoid unnecessary dependency inclusions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
