swamirishi commented on PR #6250: URL: https://github.com/apache/ozone/pull/6250#issuecomment-1958691879
> Thanks for the quick fix @aswinshakil. > > LGTM. > > Please create a follow task, if needed, as discussed offline to use cache when iterating over snapshot info table in snapshot delete service. When further thinking about it, we can still end up having duplicate entries even when we check the cache since there could be a case where the first request could be in pre execute stage when the second request is sent. The first request's validateAndUpdateCache method could be execute when the request is inflight. We need to make this operation idempotent, there is no other way going about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
