jojochuang commented on code in PR #6292:
URL: https://github.com/apache/ozone/pull/6292#discussion_r1508318676
##########
hadoop-hdds/client/src/test/java/org/apache/hadoop/hdds/scm/storage/TestBlockInputStream.java:
##########
@@ -269,6 +275,7 @@ public void testRefreshPipelineFunction() throws Exception {
seekAndVerify(50);
byte[] b = new byte[200];
blockInputStreamWithRetry.read(b, 0, 200);
+ assertThat(logCapturer.getOutput()).contains("Retry read after");
Review Comment:
Verifying debug log message is going to be brittle. But writing a test to
verify time is always tricky. What I usually do is to introduce a timer class
that wraps around Thread.sleep(), and we can verify the time does advance
(artifically). That's going to introduce big code churn with little benefit so
I'm okay with what we have now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
