Galsza commented on code in PR #6337:
URL: https://github.com/apache/ozone/pull/6337#discussion_r1514263583
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java:
##########
@@ -812,43 +811,54 @@ private static DNAction getAuditAction(Type cmdType) {
}
}
+ private static final String AUDIT_PARAM_CONTAINER_ID = "containerID";
Review Comment:
By convention the private static final constant fields are declared at the
start of the class. Please move these declarations to around line 94.
I think the audit related methods and all these constants could be moved to
a separate class/method to make HddsDispatcher shorter. What do you think
@adoroszlai ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
