smengcl commented on code in PR #4188:
URL: https://github.com/apache/ozone/pull/4188#discussion_r1558981420
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -1195,7 +1196,8 @@ public OzoneOutputStream createKey(
.setReplicationConfig(replicationConfig)
.addAllMetadata(metadata)
.setAcls(getAclList())
- .setLatestVersionLocation(getLatestVersionLocation);
+ .setLatestVersionLocation(getLatestVersionLocation)
+ .setOwnerName(ownerName);
Review Comment:
Thanks @xichen01 for explanation. Got it. So:
1. The current PR hasn't changed the ACL part yet. Thus it doesn't really
use the new **key owner** field (yet) during ACL checks.
2. In this PR, the sole purpose of key owner field as of now is to be able
to write and read the owner field.
Is my understanding correct so far?
Now I do have a follow-up question:
What is the plan on using the key owner field for ACL checks later on?
(Previously I was incorrectly assuming this PR already does what Aswin's bucket
owner PR does to ACL checks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
