errose28 commented on code in PR #6385:
URL: https://github.com/apache/ozone/pull/6385#discussion_r1595950688
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConsts.java:
##########
@@ -343,6 +343,7 @@ private OzoneConsts() {
public static final String BUCKET_LAYOUT = "bucketLayout";
public static final String TENANT = "tenant";
public static final String USER_PREFIX = "userPrefix";
+ public static final String OVERWRITE_GENERATION = "overwriteGeneration";
Review Comment:
This was meant as a more general comment on the PR which probably wasn't
clear. I think there are some places where `rewriteGeneration` makes sense,
like the audit log here and the `KeyArgs` that are passed in by the client.
Basically the places where the client is instructing the server to use the
generation for rewrite purposes. However, when the value is stored or returned
like in `OmKeyInfo` and the `KeyInfo` proto I think we should just call it
`generation`. At that point the value could technically be used for anything,
not just a rewrite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
