hemantk-12 commented on code in PR #6542:
URL: https://github.com/apache/ozone/pull/6542#discussion_r1619994343
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java:
##########
@@ -1354,7 +1354,18 @@ public ListSnapshotResponse listSnapshot(
.map(snapshotInfo -> SnapshotInfo.getFromProtobuf(snapshotInfo))
.collect(Collectors.toList());
- return new ListSnapshotResponse(snapshotInfos, response.hasLastSnapshot()
? response.getLastSnapshot() : null);
+ String lastSnapshot = null;
+
+ if (response.hasLastSnapshot()) {
+ lastSnapshot = response.getLastSnapshot();
+ } else if (snapshotInfos.size() == maxListResult) {
Review Comment:
Had an offline discussion. Since the change in proto is just adding a new
property, it is backward and forward-compatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
