[
https://issues.apache.org/jira/browse/HDDS-10934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Doroszlai updated HDDS-10934:
------------------------------------
Description:
# {{TestOzoneRpcClient}} and {{TestOzoneRpcClientWithRatis}} are subclasses of
{{TestOzoneRpcClientAbstract}}. They used to execute the same test cases with
OM Ratis disabled (relying on default setting) and enabled (explicitly),
respectively. HDDS-4498 enabled OM Ratis by default, so now both classes test
with OM Ratis enabled.
# {{TestSecureOzoneRpcClient}} should directly extend
{{TestOzoneRpcClientAbstract}} to avoid confusion caused by shadowed lifecycle
methods.
# Allow passing {{MiniOzoneCluster.Builder}} to {{startCluster}} to avoid code
duplication in {{TestSecureOzoneRpcClient}}.
# {{TestOzoneRpcClientAbstract}} should be renamed to {{OzoneRpcClientTests}}
to follow naming conventions.
was:TestOzoneRpcClient and TestOzoneRpcClientWithRatis are subclasses of
TestOzoneRpcClientAbstract. They used to execute the same test cases with OM
Ratis disabled (relying on default setting) and enabled (explicitly),
respectively. HDDS-4498 enabled OM Ratis by default, so now both classes test
with OM Ratis enabled.
> Refactor TestOzoneRpcClient hierarchy
> -------------------------------------
>
> Key: HDDS-10934
> URL: https://issues.apache.org/jira/browse/HDDS-10934
> Project: Apache Ozone
> Issue Type: Sub-task
> Components: test
> Reporter: Attila Doroszlai
> Assignee: Attila Doroszlai
> Priority: Minor
> Labels: pull-request-available
>
> # {{TestOzoneRpcClient}} and {{TestOzoneRpcClientWithRatis}} are subclasses
> of {{TestOzoneRpcClientAbstract}}. They used to execute the same test cases
> with OM Ratis disabled (relying on default setting) and enabled (explicitly),
> respectively. HDDS-4498 enabled OM Ratis by default, so now both classes
> test with OM Ratis enabled.
> # {{TestSecureOzoneRpcClient}} should directly extend
> {{TestOzoneRpcClientAbstract}} to avoid confusion caused by shadowed
> lifecycle methods.
> # Allow passing {{MiniOzoneCluster.Builder}} to {{startCluster}} to avoid
> code duplication in {{TestSecureOzoneRpcClient}}.
> # {{TestOzoneRpcClientAbstract}} should be renamed to {{OzoneRpcClientTests}}
> to follow naming conventions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
