devmadhuu commented on code in PR #6958:
URL: https://github.com/apache/ozone/pull/6958#discussion_r1680658184
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/upgrade/OMPrepareRequest.java:
##########
@@ -149,6 +157,8 @@ public OMClientResponse validateAndUpdateCache(OzoneManager
ozoneManager, TermIn
}
}
+ auditLog(auditLogger, buildAuditMessage(OMAction.UPGRADE_PREPARE,
Review Comment:
Can we add `transactionLogIndex` and `OMNodeId` in auditMap as an
additional info for audit message ?
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/upgrade/OMFinalizeUpgradeRequest.java:
##########
@@ -103,10 +110,13 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager, TermIn
ozoneManager.getVersionManager().getMetadataLayoutVersion());
LOG.trace("Returning response: {}", response);
} catch (IOException e) {
+ exception = e;
response = new OMFinalizeUpgradeResponse(
createErrorOMResponse(responseBuilder, e), -1);
}
+ auditLog(auditLogger, buildAuditMessage(OMAction.UPGRADE_FINALIZE,
+ new HashMap<>(), exception, userInfo));
Review Comment:
Can we add `termIndex` in auditMap as an additional info for audit message ?
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/upgrade/OMCancelPrepareRequest.java:
##########
@@ -82,12 +89,15 @@ public OMClientResponse validateAndUpdateCache(OzoneManager
ozoneManager, TermIn
LOG.info("OM {} prepare state cancelled at log {}. Returning response
{}",
ozoneManager.getOMNodeId(), termIndex, omResponse);
} catch (IOException e) {
+ exception = e;
LOG.error("Cancel Prepare Request apply failed in {}. ",
ozoneManager.getOMNodeId(), e);
response = new OMPrepareResponse(
createErrorOMResponse(responseBuilder, e));
}
+ auditLog(auditLogger, buildAuditMessage(OMAction.UPGRADE_CANCEL,
+ new HashMap<>(), exception, userInfo));
Review Comment:
Can we add `OMNodeId` and `termIndex` in `auditMap` as an additional info
for audit message ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
