sadanand48 commented on code in PR #6949: URL: https://github.com/apache/ozone/pull/6949#discussion_r1692576166
########## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerProtocolServerSideTranslatorPB.java: ########## @@ -218,6 +219,7 @@ private OMResponse internalProcessRequest(OMRequest request) throws this.lastRequestToSubmit = requestToSubmit; } catch (IOException ex) { if (omClientRequest != null) { + OMAuditLogger.log(omClientRequest.getAuditBuilder()); Review Comment: Based on offline discussion , We don't write audits for failures in preExecute in every case. Some cases where audits are written in preExecute phase: 1. OMCancelDelegationTokenRequest 2. OMGetDelegationTokenRequest 3. OMRenewDelegationTokenRequest The same behaviour is retained with this patch too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org