ChenSammi commented on code in PR #7013: URL: https://github.com/apache/ozone/pull/7013#discussion_r1699948481
########## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java: ########## @@ -545,22 +545,34 @@ public static OMRequest blockCommitKeyWithBucketLayoutFromOldClient( return req; } + /** + * Validates key commit requests. + * We do not want to allow clients to perform hsync or lease recovery requests + * until the cluster has finalized the HBase support feature. + * + * @param req - the request to validate + * @param ctx - the validation context + * @return the validated request + * @throws OMException if the request is invalid + */ @RequestFeatureValidator( conditions = ValidationCondition.CLUSTER_NEEDS_FINALIZATION, processingPhase = RequestProcessingPhase.PRE_PROCESS, requestType = Type.CommitKey ) - public static OMRequest disallowHsync( + public static OMRequest disallowHBase( Review Comment: Am I missing something? I didn't find where this disallowHsync or disallowHBase is called. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org