hemantk-12 commented on code in PR #7014:
URL: https://github.com/apache/ozone/pull/7014#discussion_r1700595688
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RocksDBConfiguration.java:
##########
@@ -46,6 +46,20 @@ public class RocksDBConfiguration {
description = "OM RocksDB logging level (INFO/DEBUG/WARN/ERROR/FATAL)")
private String rocksdbLogLevel;
+ @Config(key = "rocksdb.max.log.file.size",
+ type = ConfigType.SIZE,
+ defaultValue = "0MB",
+ tags = {OM, SCM, DATANODE},
+ description = "Maximum size of RocksDB application log file.")
+ private long rocksdbMaxLogFileSize = 0;
+
+ @Config(key = "rocksdb.keep.log.file.num",
+ type = ConfigType.INT,
+ defaultValue = "1000",
+ tags = {OM, SCM, DATANODE},
+ description = "Maximum number of RocksDB application log files.")
+ private int rocksdbKeepLogFileNum = 1000;
Review Comment:
Yes,
[keep_log_file_num](https://github.com/facebook/rocksdb/blob/main/include/rocksdb/options.h#L874)
as mentioned in the description.
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RocksDBConfiguration.java:
##########
@@ -46,6 +46,20 @@ public class RocksDBConfiguration {
description = "OM RocksDB logging level (INFO/DEBUG/WARN/ERROR/FATAL)")
private String rocksdbLogLevel;
+ @Config(key = "rocksdb.max.log.file.size",
+ type = ConfigType.SIZE,
+ defaultValue = "0MB",
Review Comment:
Yes,
[max_log_file_size](https://github.com/facebook/rocksdb/blob/main/include/rocksdb/options.h#L864)
as mentioned in the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
