sumitagrawl commented on PR #7031: URL: https://github.com/apache/ozone/pull/7031#issuecomment-2272674522
> @ArafatKhan2198 this will cause DN memory to grow proportionally to the number of blocks deleted, something we don't want. Can't we just move the metrics increment to happen after the DN identifies the block as already being deleted because it is no longer present? @errose28 metrics are preserved in DB, and to update same, blockInfo is used to define block exist or not for atomicity. There is an issue in handling the logic, where if duplicate comes in same batch but with different transaction. Also we can not depend on disk status due to error scenario, and db have atomic operation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
