hemantk-12 commented on PR #7018: URL: https://github.com/apache/ozone/pull/7018#issuecomment-2289411138
> But it wouldn't hurt to have the locking right? Any particular reason why we are removing the locks? Yes, it is not causing any issues. But these locks are unnecessary right now and are just increasing the complexity. As mentioned in the description, these locks were added mainly because SSTFilteringService was updating SnapshotInfoTable directly, HDDS-10590. But, in HDDS-11068, we figured that even after adding the locks, it didn't solve the problem and the snapshot chain corruption issue persisted if OM crashed and the double buffer was not flushed. > Since future changes could still impact this right? As long as any update to SnapshotInfoTable goes through Ratis, we don't need these locks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
