devabhishekpal commented on PR #7060: URL: https://github.com/apache/ozone/pull/7060#issuecomment-2295781075
Hi @ivandika3 @adoroszlai , It seems the failure in the [build-branch / CI / integration (om)](https://github.com/apache/ozone/actions/runs/10442489168/job/28922224092) is because the generated proto file has the enum for [ListTrash](https://github.com/apache/ozone/blob/7f24f2d3e41c4bffb94bd93b4b1adcf075da082c/hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto#L100) and [RecoverTrash](https://github.com/apache/ozone/blob/7f24f2d3e41c4bffb94bd93b4b1adcf075da082c/hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto#L101) present. But in the code for the test we are missing this from the OmUtils switch-case. So I tried out with marking the enum numbers as reserved, also tried marking as deprecated. But it seems in current protoc version this is not supported. So there are the following ways: - Keep the cases for listTrash and recoverTrash in switch() in OmUtils, but all other references are removed, so unless there is any way in which this switch case is being hit apart from via the test it won't break anything - Restore the method definitions, throw an `UnsupportedOperationException()` on the implementations and marking both interface and impl as deprecated. When we are upgraded to protoc3 I believe we can safely remove these defs. Wanted inputs on this and if there is any other way. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
