ChenSammi commented on code in PR #7016: URL: https://github.com/apache/ozone/pull/7016#discussion_r1726463169
########## hadoop-ozone/dist/src/main/smoketest/omha/om-roles.robot: ########## @@ -53,3 +53,15 @@ List om roles as JSON without OM service ID passed Assert Leader Present in JSON ${output_without_id_passed} ${output_without_id_passed} = Execute And Ignore Error ozone admin --set=ozone.om.service.ids=omservice,omservice2 om roles --json Should Contain ${output_without_id_passed} no Ozone Manager service ID specified + +List om roles as TABLE with OM service ID passed + ${output_with_id_passed} = Execute ozone admin om roles --service-id=omservice --table + Assert Leader Present ${output_with_id_passed} + ${output_with_id_passed} = Execute ozone admin --set=ozone.om.service.ids=omservice,omservice2 om roles --service-id=omservice --table + Assert Leader Present ${output_with_id_passed} + +List om roles as TABLE without OM service ID passed + ${output_without_id_passed} = Execute ozone admin om roles --table + Assert Leader Present ${output_without_id_passed} Review Comment: Should this "Assert Leader Present" fail for the table case? For the output string pattern is different. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org