ivandika3 commented on code in PR #6960:
URL: https://github.com/apache/ozone/pull/6960#discussion_r1762247773
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java:
##########
@@ -447,6 +449,8 @@ public RegisteredCommand register(
processNodeReport(datanodeDetails, nodeReport);
LOG.info("Updated datanode to: {}", dn);
scmNodeEventPublisher.fireEvent(SCMEvents.NODE_ADDRESS_UPDATE, dn);
+ } else if (isVersionChange(oldNode.getVersion(),
datanodeDetails.getVersion())) {
+ nodeStateManager.updateNode(datanodeDetails, layoutInfo);
Review Comment:
I see, I think it should be fine. Could you update the related comment
("Update datanode if it is registered....") and add some INFO logs regarding
the version change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
