szetszwo commented on code in PR #7291:
URL: https://github.com/apache/ozone/pull/7291#discussion_r1795752995
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHADBTransactionBufferImpl.java:
##########
@@ -107,6 +111,7 @@ public SnapshotInfo getLatestSnapshot() {
@Override
public void setLatestSnapshot(SnapshotInfo latestSnapshot) {
+ LOG.info("Set latest Snapshot to {}", latestSnapshot);
Review Comment:
Please add server id.
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMStateMachine.java:
##########
@@ -149,6 +150,9 @@ public CompletableFuture<Message> applyTransaction(
final SCMRatisRequest request = SCMRatisRequest.decode(
Message.valueOf(trx.getStateMachineLogEntry().getLogData()));
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("applyTransaction {}", TermIndex.valueOf(trx.getLogEntry()));
Review Comment:
Please add server id.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerStateMachine.java:
##########
@@ -427,12 +433,14 @@ public synchronized void pause() {
*/
public synchronized void unpause(long newLastAppliedSnaphsotIndex,
long newLastAppliedSnapShotTermIndex) {
- LOG.info("OzoneManagerStateMachine is un-pausing");
if (statePausedCount.decrementAndGet() == 0) {
getLifeCycle().startAndTransition(() -> {
this.ozoneManagerDoubleBuffer = buildDoubleBufferForRatis();
this.setLastAppliedTermIndex(TermIndex.valueOf(
newLastAppliedSnapShotTermIndex, newLastAppliedSnaphsotIndex));
+ LOG.info("OzoneManagerStateMachine un-pause completed. " +
Review Comment:
Please add server id.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerStateMachine.java:
##########
@@ -341,6 +346,7 @@ public CompletableFuture<Message>
applyTransaction(TransactionContext trx) {
: OMRatisHelper.convertByteStringToOMRequest(
trx.getStateMachineLogEntry().getLogData());
final TermIndex termIndex = TermIndex.valueOf(trx.getLogEntry());
+ LOG.debug("applyTransaction {}", termIndex);
Review Comment:
Please add server id.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerStateMachine.java:
##########
@@ -482,15 +490,15 @@ private synchronized long takeSnapshotImpl() throws
IOException {
final TermIndex applied = getLastAppliedTermIndex();
final TermIndex notified = getLastNotifiedTermIndex();
final TermIndex snapshot = applied.compareTo(notified) > 0 ? applied :
notified;
- LOG.info(" applied = {}", applied);
- LOG.info(" skipped = {}", lastSkippedIndex);
- LOG.info("notified = {}", notified);
- LOG.info("snapshot = {}", snapshot);
+ long startTime = Time.monotonicNow();
final TransactionInfo transactionInfo = TransactionInfo.valueOf(snapshot);
ozoneManager.setTransactionInfo(transactionInfo);
ozoneManager.getMetadataManager().getTransactionInfoTable().put(TRANSACTION_INFO_KEY,
transactionInfo);
ozoneManager.getMetadataManager().getStore().flushDB();
+ LOG.info("Taking snapshot. applied = {}, skipped = {}, " +
Review Comment:
Please add server id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
