ivanzlenko commented on code in PR #7139:
URL: https://github.com/apache/ozone/pull/7139#discussion_r1814545764
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerTaskIterationStatusInfo.java:
##########
@@ -18,86 +18,184 @@
package org.apache.hadoop.hdds.scm.container.balancer;
+import
org.apache.hadoop.hdds.protocol.proto.StorageContainerLocationProtocolProtos;
+
+import java.util.List;
import java.util.Map;
+import java.util.Optional;
import java.util.UUID;
+import java.util.stream.Collectors;
/**
* Information about balancer task iteration.
*/
public class ContainerBalancerTaskIterationStatusInfo {
private final Integer iterationNumber;
private final String iterationResult;
- private final long sizeScheduledForMoveGB;
- private final long dataSizeMovedGB;
+ private final long iterationDuration;
+ private final long sizeScheduledForMove;
+ private final long dataSizeMoved;
private final long containerMovesScheduled;
private final long containerMovesCompleted;
private final long containerMovesFailed;
private final long containerMovesTimeout;
- private final Map<UUID, Long> sizeEnteringNodesGB;
- private final Map<UUID, Long> sizeLeavingNodesGB;
+ private final Map<UUID, Long> sizeEnteringNodes;
+ private final Map<UUID, Long> sizeLeavingNodes;
@SuppressWarnings("checkstyle:ParameterNumber")
public ContainerBalancerTaskIterationStatusInfo(
Review Comment:
It is NOT okay to follow bad practices. Please fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
