errose28 commented on code in PR #7293:
URL: https://github.com/apache/ozone/pull/7293#discussion_r1853111584
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/checksum/ContainerChecksumTreeManager.java:
##########
@@ -157,22 +158,22 @@ public ContainerDiffReport diff(KeyValueContainerData
thisContainer,
Preconditions.assertNotNull(peerChecksumInfo, "Peer checksum info is
null");
Optional<ContainerProtos.ContainerChecksumInfo>
thisContainerChecksumInfo = read(thisContainer);
if (!thisContainerChecksumInfo.isPresent()) {
- throw new SCMException("The container #" +
thisContainer.getContainerID() +
- " doesn't have container checksum",
SCMException.ResultCodes.IO_EXCEPTION);
+ throw new StorageContainerException("The container #" +
thisContainer.getContainerID() +
+ " doesn't have container checksum",
ContainerProtos.Result.IO_EXCEPTION);
Review Comment:
We are using the same result code for this case and the legitimate IO
exception case. This might be okay because we could want the caller to queue
the scanner for on demand scanning in both cases. We can leave it for now and
revisit in the follow up patch that needs to handle this if required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
