tsreaper commented on code in PR #719:
URL: https://github.com/apache/incubator-paimon/pull/719#discussion_r1148737481
##########
paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/sink/CommitterOperatorTest.java:
##########
@@ -246,7 +256,7 @@ private OneInputStreamOperatorTestHarness<Committable,
Committable> createLossyT
new CommitterOperator(
true,
initialCommitUser,
- user -> new StoreCommitter(table.newCommit(user)),
+ user -> new
StoreCommitter(table.newStreamWriteBuilder().newCommit()),
Review Comment:
You forgot `withCommitUser`. I'm thinking if we need to force users to
specify a `commitUser` when using `StreamWriteBuilder`, instead of generating a
random UUID for them. @JingsongLi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
