legendtkl commented on code in PR #714:
URL: https://github.com/apache/incubator-paimon/pull/714#discussion_r1153125664
##########
paimon-common/src/main/java/org/apache/paimon/io/cache/CachedRandomInputView.java:
##########
@@ -55,7 +55,7 @@ public CachedRandomInputView(File file, CacheManager
cacheManager)
this.file = new RandomAccessFile(file, "r");
this.fileLength = file.length();
this.cacheManager = cacheManager;
- this.segments = new HashMap<>();
+ this.segments = new ConcurrentHashMap<>();
Review Comment:
@SteNicholas yes, once we replace computeIfAbsent log, it's ok to use
HashMap.
Let's keep the hashmap left.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
