Alibaba-HZY commented on code in PR #831: URL: https://github.com/apache/incubator-paimon/pull/831#discussion_r1157453382
########## paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveCatalogFactoryOptions.java: ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.paimon.hive; + +import org.apache.paimon.options.ConfigOption; +import org.apache.paimon.options.ConfigOptions; + +/** {@link ConfigOption}s for {@link HiveCatalog}. */ +public final class HiveCatalogFactoryOptions { + + public static final String IDENTIFIER = "hive"; + + public static final ConfigOption<String> HIVE_CONF_DIR = + ConfigOptions.key("hive-conf-dir").stringType().noDefaultValue(); + + public static final ConfigOption<String> HADOOP_CONF_DIR = + ConfigOptions.key("hadoop-conf-dir").stringType().noDefaultValue(); Review Comment: HadoopUtils.PATH_HADOOP_CONFIG is Deprecated, in flink, if the user does not configure hadoop-conf-dir, it will search in four paths , including HadoopUtils.PATH_HADOOP_CONFIG,System.getenv("HADOOP_CONF_DIR”),System.getenv("HADOOP_HOME") + "/conf",System.getenv("HADOOP_HOME") + "/etc/hadoop". Now I only in the user configuration of hadoop - conf - dir path search the xml file, so we can keep the hadoop-conf-dir option? and then if the hadoop-conf-dir is empty, then use HadoopUtils.GetHadoopConfiguration to find xml file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
