[GitHub] [incubator-paimon] SteNicholas commented on a diff in pull request #772: [hive] Dropping table deletes table directory to avoid schema in filesystem exists

[via GitHub]

SteNicholas commented on code in PR #772:
URL: https://github.com/apache/incubator-paimon/pull/772#discussion_r1158036232


##########
paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveCatalog.java:
##########
@@ -208,6 +208,16 @@ public void dropTable(Identifier identifier, boolean 
ignoreIfNotExists)
                     identifier.getDatabaseName(), identifier.getObjectName(), 
true, false, true);
         } catch (TException e) {
             throw new RuntimeException("Failed to drop table " + 
identifier.getFullName(), e);
+        } finally {
+            // Deletes table directory to avoid schema in filesystem exists.
+            Path path = getDataTableLocation(identifier);
+            try {
+                if (fileIO.exists(path)) {
+                    fileIO.deleteDirectoryQuietly(path);

Review Comment:
   @FangYongs, `paimonTableExists` depends on whether the table in hive exist, 
not the table on filesystem. Therefore, when the table in hive isn't delete, 
`paimonTableExists` also return true and the table in hive could also be 
dropped.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org