SteNicholas commented on code in PR #898:
URL: https://github.com/apache/incubator-paimon/pull/898#discussion_r1165356289
##########
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommit.java:
##########
@@ -72,4 +73,7 @@ void overwrite(
* @param partitions A list of partition {@link Map}s. NOTE: cannot be
empty!
*/
void dropPartitions(List<Map<String, String>> partitions, long
commitIdentifier);
+
+ /** Abort an unsuccessful commit. The data files will be deleted. */
+ void abort(List<CommitMessage> commitMessages);
Review Comment:
Could the param use `ManifestCommittable`? IMO, `FileStoreCommit` interface
doesn't expose the `CommitMessage` but expose `ManifestCommittable`, therefore
it's better to use `ManifestCommittable` as the param of `abort`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
