liming30 commented on code in PR #1301:
URL: https://github.com/apache/incubator-paimon/pull/1301#discussion_r1218285015
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/source/StaticFileStoreSource.java:
##########
@@ -53,11 +69,42 @@ public SplitEnumerator<FileStoreSourceSplit,
PendingSplitsCheckpoint> restoreEnu
PendingSplitsCheckpoint checkpoint) {
Collection<FileStoreSourceSplit> splits =
checkpoint == null ? getSplits() : checkpoint.splits();
- return new StaticFileStoreSplitEnumerator(context, null, splits,
splitBatchSize);
+ SplitAssigner splitAssigner =
+ createSplitAssigner(context, splitBatchSize, splitAssignMode,
splits);
+ return new StaticFileStoreSplitEnumerator(context, null,
splitAssigner);
}
private List<FileStoreSourceSplit> getSplits() {
FileStoreSourceSplitGenerator splitGenerator = new
FileStoreSourceSplitGenerator();
return splitGenerator.createSplits(readBuilder.newScan().plan());
}
+
+ public static SplitAssigner createSplitAssigner(
Review Comment:
Sorry, I don't quite understand why this method needs to be moved to
`FairSplitAssigner`. Maybe you mean
[`createSplitAssignment`](https://github.com/apache/incubator-paimon/pull/1301/files#diff-a12ee210f24e59beb65f3d656f97ac8aa4d16dcce95b2491ce61ae83ce734a1aR99)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
