zhangjun0x01 commented on code in PR #1662:
URL: https://github.com/apache/incubator-paimon/pull/1662#discussion_r1277154054
##########
paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveCatalog.java:
##########
@@ -313,10 +313,10 @@ public void createTable(Identifier identifier, Schema
schema, boolean ignoreIfEx
e);
}
Table table = newHmsTable(identifier);
- updateHmsTable(table, identifier, tableSchema);
try {
+ updateHmsTable(table, identifier, tableSchema);
Review Comment:
the method `updateHmsTable `. do not generate schema file , but it may
throw an exception , we do not try catch it .
and I add a test case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
