Re: [PR] [Core] Support branch batch/streaming read and write [incubator-paimon]

[via GitHub]

TaoZex commented on code in PR #2748:
URL: https://github.com/apache/incubator-paimon/pull/2748#discussion_r1466162019


##########
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java:
##########
@@ -694,10 +707,14 @@ public boolean tryCommitOnce(
             Snapshot.CommitKind commitKind,
             @Nullable Snapshot latestSnapshot,
             @Nullable Long safeLatestSnapshotId,
+            String branchName,
             @Nullable String newStatsFileName) {
         long newSnapshotId =
                 latestSnapshot == null ? Snapshot.FIRST_SNAPSHOT_ID : 
latestSnapshot.id() + 1;
-        Path newSnapshotPath = snapshotManager.snapshotPath(newSnapshotId);
+        Path newSnapshotPath =
+                branchName.equals(MAIN_BRANCH)

Review Comment:
   It will call the getBranchPath method.
   
![image](https://github.com/apache/incubator-paimon/assets/45089228/1f215d3d-7e04-41c2-a2b8-2d4c222ca7f7)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org