Aitozi commented on code in PR #3178:
URL: https://github.com/apache/paimon/pull/3178#discussion_r1570006850
##########
paimon-spark/paimon-spark-common/src/test/scala/org/apache/paimon/spark/procedure/ExpireSnapshotsProcedureTest.scala:
##########
@@ -71,7 +71,7 @@ class ExpireSnapshotsProcedureTest extends
PaimonSparkTestBase with StreamTest {
// expire
checkAnswer(
- spark.sql("CALL paimon.sys.expire_snapshots(table => 'test.T',
retain_max => 2)"),
+ spark.sql("CALL paimon.sys.expire_snapshots(table => 'test.T',
retain_max => 2, retain_min => 1)"),
Review Comment:
Before, if user not specify the `retain_min`, the default value is 1 in
`ExpireSnapshotsImpl`, now the default value is fallback to the
`CoreOptions.SNAPSHOT_RETAIN_MIN = 10`, so if max is 2, we should manually
specify the `retain_min => 1`. I think the current behavior is more consistent,
I'm not sure whether this will break the compatibility. Please also help check
this cc @JingsongLi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
