JingsongLi commented on code in PR #3421:
URL: https://github.com/apache/paimon/pull/3421#discussion_r1618445072
##########
paimon-core/src/main/java/org/apache/paimon/partition/PartitionPredicate.java:
##########
@@ -121,8 +121,11 @@ private MultiplePartitionPredicate(
PredicateBuilder builder = new PredicateBuilder(partitionType);
for (int i = 0; i < collectors.length; i++) {
SimpleColStats stats = collectors[i].result();
- min[i] = builder.greaterOrEqual(i, stats.min());
- max[i] = builder.lessOrEqual(i, stats.max());
+ Object minValue = stats.min();
+ Object maxValue = stats.max();
+
+ min[i] = minValue == null ? builder.isNull(i) :
builder.greaterOrEqual(i, minValue);
+ max[i] = maxValue == null ? builder.isNull(i) :
builder.lessOrEqual(i, maxValue);
Review Comment:
I see, if it is null, all values are null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
