schnappi17 commented on code in PR #3414:
URL: https://github.com/apache/paimon/pull/3414#discussion_r1619812775


##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/log/LogSourceProvider.java:
##########
@@ -40,4 +40,7 @@ public interface LogSourceProvider extends Serializable {
      * @param bucketOffsets optional, configure if you need to specify the 
startup offset.
      */
     Source<RowData, ?, ?> createSource(@Nullable Map<Integer, Long> 
bucketOffsets);
+
+    /** Pre-operations before create log {@link Source}. */

Review Comment:
   > Add more comments? I'm worried that someone might find this method useless 
in the future and delete it..
   
   @JingsongLi Updated, please help to take a look at.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to